palantir/blueprint

FR: Support small modifier for NumericInput

Open

#3,132 opened on Nov 7, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P3Package: coreType: feature requesthelp wanted

Description

Environment

  • Package version(s): 3.8
  • Browser and OS versions: Chrome 70

Feature request

I like to make a form using small modifier on components. I can use small modifier on InputGroup and Button but MenuItem and NumericInput does not support small modifier. I tried className={Classes.SMALL} but it did not work. You can look at screenshot below as an example

Could you implement support for these components? Probably there are other components that does not support small modifier. I prefer support for all components which can be used inside a form.

Examples

<Button small={true} rightIcon="double-caret-vertical" .../> <InputGroup small={true} .../> <NumericInput leftIcon="arrow-top-left" .../> // does not support small modifier <NumericInput .../>

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Blueprint component patternsUnderstanding of TypeScript and React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue requests adding a 'small' modifier to NumericInput, similar to existing support in Button and InputGroup. Research the implementation of the 'small' prop in those components (e.g., Button.tsx and InputGroup.tsx) to understand the pattern. Then examine NumericInput.tsx and its associated styles in numeric input.scss to add the Small modifier. The issue mentions that className={Classes.SMALL} did not work, so the fix likely involves adding a prop or CSS class that applies the small size styling. There are no linked PRs or maintainer comments, so the implementation is straightforward and can follow the existing pattern.