palantir/blueprint

FileInput should support "directory" prop

Open

#3,126 opened on Nov 5, 2018

View on GitHub
 (7 comments) (1 reaction) (0 assignees)TypeScript (2,167 forks)batch import
P3Package: coreType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Environment

  • Package version(s): not applicable
  • Browser and OS versions: not applicable

Feature request

FileInput does not support mozdirectory, directory, webkitdirectory or nwdirectory.

Per https://github.com/facebook/react/issues/3468#issuecomment-328197124 React does not support this specifically but the props can be added.

This feature allows selecting a directory itself vs files inside a directory.

Examples

Instead of having to define all 4 props above, directory could be used to add all at once.

Contributor guide

Research direction
Inspect the FileInput component source code, understand how props are passed to the underlying <input> element, and add support for the directory prop by passing it along with other allowed HTML attributes. Refer to the React issue linked for context.
Tech stack
reacttypescript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80