palantir/blueprint

blueprint v3 autofocus in InputGroup (probably others) inside of popover causing scroll to jump

Open

#2,864 opened on Aug 22, 2018

View on GitHub
 (10 comments) (1 reaction) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: bughelp wanted

Description

I have an InputGroup with autoFocus=true inside a popover that must be scrolled to be reached. When I open the popover, the page is scrolled to the very top, even though all I did was click a button. You can see this in the gif below:

untitled1

I imagine that this isn't just confined to InputGroup but probably any blueprint element that can autofocus.

Here's a reproduction of it:

https://codesandbox.io/s/m38yvkywxp

Thanks!

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScriptDOM focus events
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the autofocus behavior in Blueprint's InputGroup and Popover components. Review the reproduction at the provided CodeSandbox link. Look for any focus related logic that might trigger window.scrollTo or scrollIntoView. Check if there's a known fix or similar issues in the repository. Consider testing a fix that prevents scroll jumping when focus is set within a popover.
blueprint v3 autofocus in InputGroup (probably others) inside of popover causing scroll to jump · palantir/blueprint#2864 | Good First Issue