palantir/blueprint

<ButtonGroup> in <InputGroup> has extra margin

Open

#2,805 opened on Aug 15, 2018

View on GitHub
 (10 comments) (0 reactions) (1 assignee)TypeScript (20,263 stars) (2,167 forks)batch import
Package: coreType: bughelp wanted

Description

Environment

  • Package version(s): 3.0.0
  • Browser and OS versions: Chrome 68.0.3440.106 and Safari 11.1.2 on MacOS 10.13.6

Steps to reproduce

  1. Create an <InputGroup>
  2. Create a <ButtonGroup> and assign it to the rightElement of the <InputGroup> in step 1
  3. Add 2 <Button>s to the <ButtonGroup> in step 2

Actual behavior

screen shot 2018-08-15 at 4 13 52 pm

Child <Button>s of a <ButtonGroup> which is the rightElement of an <InputGroup> have extra margins, so they don't line up next to each other.

Expected behavior

Child <Button>s of a <ButtonGroup> which is the rightElement of an <InputGroup> should line up next to each other.

Possible solution

Add a specific rule to reset the margin of a <Button> when it's nested in a <ButtonGroup> that's nested in an <InputGroup>

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSS specificityReact component nesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the CSS files for ButtonGroup and InputGroup components in the Blueprint repository, likely in packages/core/src/components/button group and packages/core/src/components/input group. The issue is about extra margin on buttons inside a ButtonGroup that is used as the rightElement of an InputGroup. The solution involves adding a CSS rule to reset margin for buttons in that specific nesting context, possibly using a descendant selector like `.blueprint input group .blueprint button group .blueprint button`. Check the existing styles for any overrides and test in a browser.