palantir/blueprint

[Table] Feature Request: Add an onStartEditing event handler to EditableCell

Open

#2,682 opened on Jul 12, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Package: tableType: feature requesthelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

It would be quite helpful to have an onStartEditing event handler on EditableCell that takes a function that is passed a row and column. This allow would show additional custom elements (select, autocomplete and etc.).

Example: _add_on_edit

Contributor guide

Research direction
Look at the EditableCell component in the Blueprint source code, particularly its props and event handling. Identify where cell editing starts and add a new prop for onStartEditing that accepts a callback with row and column indices. Then ensure the callback is invoked at the start of edit mode.
Tech stack
typescriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactTypeScriptBlueprint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70