palantir/blueprint

[Table] Feature Request: Add an onStartEditing event handler to EditableCell

Open

#2,682 opened on Jul 12, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: tableType: feature requesthelp wanted

Description

It would be quite helpful to have an onStartEditing event handler on EditableCell that takes a function that is passed a row and column. This allow would show additional custom elements (select, autocomplete and etc.).

Example: _add_on_edit

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of ReactFamiliarity with Blueprint's EditableCell component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the EditableCell component source in the Blueprint repository to understand existing event handlers (onConfirm, onCancel). Implement a new onStartEditing prop that triggers when the cell enters edit mode. Look at how other cell event handlers pass row and column data. Check the issue comments for any additional requirements or discussion. The implementation should follow the pattern of existing handlers.
[Table] Feature Request: Add an onStartEditing event handler to EditableCell · palantir/blueprint#2682 | Good First Issue