palantir/blueprint

Configure the default time when selecting a day in a DateRangeInput

Open

#2,625 opened on Jun 25, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: datetimeType: feature requesthelp wanted

Description

Environment

  • Package version(s): 1.36.1 & 2.3.1

Feature request

Hi, it would be convenient if we could configure the default time when selecting a date in a Date range input. Right now when a user selects a date, the default time is "12:00:00". I believe this is hardcoded in this file

If we keep a hardcoded value for the time, I believe "00:00" would be a better choice.

Examples

Create a DateRangeInput and select any Date, the default time will be "12:00"

Contributor guide

Tech stack
typescriptreacthtmlcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
React component developmentUnderstanding of DateRangeInput component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the file packages/datetime/src/datePicker.tsx around line 268 to understand how the default time is currently hardcoded. Review existing DateRangeInput props to see if any allow time customization. Consider adding a prop for default time or changing the hardcoded value to '00:00:00' as suggested. Check if there are any linked discussions or PRs for further context.