palantir/blueprint

DateInput handles blur and key down Enter on the input field differently.

Open

#2,550 opened on May 29, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: datetimeType: enhancementhelp wanted

Description

Environment

  • Package version(s): blueprintjs/datetime@2.0.0
  • Browser and OS versions: Chrome

Steps to reproduce

  1. With
<DateInput
  minDate={new Date('2018-01-01T00:00:00Z')}
  maxDate={new Date('2019-01-01T00:00:00Z')}
  onChange={val => console.log('onChange', val)}
  onError={val => console.log('onError', val)}
/>
  1. On filling in 05/29/3018 into the input as string and blurring the input, you see onError Fri May 29 3018 09:00:00 GMT+0200 (CEST)
  2. On filling in 05/29/3018 and then hitting Enter, you can see onChange Fri May 29 3018 09:00:00 GMT+0200 (CEST)

Actual behavior

Expected behavior

I would expect that whether input is blurred or whether I hit Enter, both ways will trigger the same handler, which according to documentation should be onError as date is out of range.

Possible solution

On handleInputBlur there is correct code that calls onChange or onError depending on the validity of the value but in handleDateChange which is called in handleInputKeyDown this is not implemented and onChange is called with invalid inputs.

Contributor guide

Tech stack
reacttypescript
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
The bug is in the DateInput component in `packages/datetime/src/dateInput.tsx`. The issue is that `handleInputBlur` correctly calls `onChange` or `onError` based on date validity, but `handleDateChange` (called on Enter key) does not. The fix should add similar validation logic to `handleDateChange`, likely by reusing the same validation function used in `handleInputBlur`. Refer to the linked lines in the issue for exact code.
DateInput handles blur and key down Enter on the input field differently. · palantir/blueprint#2550 | Good First Issue