palantir/blueprint

Proposal: Make icons multipath for more advanced CSS styling

Open

#2,389 opened on Apr 13, 2018

View on GitHub
 (32 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: iconsType: enhancementhelp wanted

Description

It would be great if icons that consist of multiple elements would have multiple paths, each with class name that could be used to style it (CSS).

For example: cloud-download would have 2 paths, one for cloud, one for down arrow. Each path would have it's own class name accessible using CSS for styling purposes.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SVG conceptsReactCSS styling of SVG
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Start by examining the current icon implementation in the Blueprint repository, likely in the 'icons' or 'icon' directory. Understand how each icon is defined as a React component and how paths are structured. The issue requests splitting icons like 'cloud download' into multiple paths (e.g., cloud shape and arrow) with distinct class names. Look at the existing icon generation script and SVG rendering code. Check the 32 comments for any proposed approaches or maintainer feedback. Consider how to add class names to individual paths without breaking existing usage.
Proposal: Make icons multipath for more advanced CSS styling · palantir/blueprint#2389 | Good First Issue