palantir/blueprint

Using EditableText in selected tree element leads to unreadable text

Open

#2,236 opened on Mar 14, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
Package: coreType: bughelp wanted

Description

Bug report

  • Package version(s):
    "@blueprintjs/core": "^2.0.0-rc.2",
    "@blueprintjs/icons": "^2.0.0-rc.2",
    "@blueprintjs/table": "^2.0.0-rc.2",
  • Browser and OS versions: Chrome 64.0.3282.186 on OS X

Steps to reproduce

  1. Create
  2. Add child element with EditableText as label
  3. Select element and start editing

Actual behavior

The editable text is unreadable because it's white text on white background.

style-problem

Expected behavior

Visibly different colors for text and background.

Shouldn't pt.editable-text.pt-editable-editing set the text-color when setting the background-color? Setting only one of them sounds like inviting this kind of problems.

Contributor guide

Tech stack
typescriptreactcss
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
CSSReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80
Research direction
Investigate the CSS for the Tree component's selected state. The issue describes that when using EditableText as a label in a selected tree element, the text becomes unreadable due to white text on white background. Look at the CSS selector `.pt editable text.pt editable editing` and ensure that both `color` and `background color` are set appropriately. The fix likely involves adding a specific color override for the editing state within the selected tree element. Check the relevant SCSS files in the Blueprint codebase, such as those for Tree and EditableText components.