palantir/blueprint

[EditableText] Add support for rightElements in EditableText

Open

#2,185 opened on Feb 26, 2018

View on GitHub
 (6 comments) (2 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: coreType: feature requesthelp wanted

Description

Title says it all.

Edit: More Details

When an EditableText is being edited, I would like for the rendered input or textarea to display a minimal button or tag on the right, as can be done via the rightElement prop on an InputGroup.

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with React componentsUnderstanding of Blueprint's EditableText component
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Inspect the EditableText component source in the Blueprint codebase. Look at how InputGroup implements rightElement to understand the pattern. Consider adding a new prop to EditableText that accepts a React node to be rendered on the right side when editing. The issue has no linked PRs or maintainer comments, so implement based on the existing InputGroup pattern.