palantir/blueprint

NumericInput - prevent exceeding min or max when typing or pasting values

Open

#2,071 opened on Feb 2, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)TypeScript (2,167 forks)batch import
Package: coreType: enhancementhelp wanted

Repository metrics

Stars
 (20,263 stars)
PR merge metrics
 (Avg merge 43d 10h) (27 merged PRs in 30d)

Description

Current NumericInput implementation caps properly at bounds when using the mouse, but when one types or pastes a value, the input should prevent typing a value exceeding the limits, it currently does not and users can type garbage.

One way to prevent this is, until a solution appears, is to check again the bounds in the onValueChange event, but is redundant.

Contributor guide

Research direction
Examine the NumericInput component's input event handlers (e.g., onChange, onKeyDown) and pasting logic. Identify where bounds checking is missing and add validation to prevent values from exceeding min or max during typing or pasting. Focus on the input's value change flow and ensure it clamps or rejects invalid values.
Tech stack
typescriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitReactTypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70