palantir/blueprint

[DateTime] Decouple "Enter to close" from "closeOnSelection" for DateInput/DateRangeInput

Open

#1,988 opened on Jan 11, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)TypeScript (20,263 stars) (2,167 forks)batch import
P2Package: datetimeType: enhancementhelp wanted

Description

Feature request:

Allow more flexible control over when the popup closes for both DateInput and DateRangeInput

Currently, enter to close only works if "closeOnSelection" is true.

See also: #1825

Contributor guide

Tech stack
typescriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ReactBlueprint DateInput/DateRangeInput
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the DateInput and DateRangeInput components in the Blueprint repository (likely under packages/datetime/src). Look at the current implementation of closeOnSelection and the Enter key handler. Refer to the linked issue #1825 for context. The goal is to separate the Enter to close behavior from closeOnSelection, possibly adding a new prop like 'closeOnEnter'. Start by examining the component's internal state and event handling.