pahen/madge

fix output.sh syntax

Open

#390 opened on Oct 22, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (8,058 stars) (322 forks)batch import
good first issue

Description

function desc() {
	echo "\033[01;38;5;022m############### $1 ###############\033[0m";
}

the "function" builtin exists in bash, so it need to parsing as posix in test/output.sh

$ type function function is a reserved word

Contributor guide

Tech stack
shell
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue involves replacing the bash specific 'function' keyword with a POSIX compatible function definition in test/output.sh. The current line 'function desc() {' should be changed to 'desc() {'. Also remove the closing 'function' if present. This is a simple, localized change that does not require additional context.