New, flattened lottie schema doesn't work: 'if/then/else schemas are not supported'

Open
#927 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
rust
Domain
compilers

Research direction

Reproduce the panic with the flattened Lottie schema and inspect typify-impl-0.5.0/src/merge.rs at the reported line. Compare the schema and the unsupported if/then/else handling to determine whether the change belongs in typify or the schema; done means the schema can be processed without this panic.

Written by the indexing model from the issue text.

Description

Due to the problem in #907 reported, I requested a new flattened schema from the lottie team.

They actually made a new format to be compliant with type generators, that conversation happened here: https://github.com/lottie/lottie-spec/issues/157

However, unfortunately, it looks like there's another issue.

Can

  --- stderr

  thread 'main' (531858) panicked at /home/robo/.cargo/registry/src/index.crates.io-1949cf8c6b5b557f/typify-impl-0.5.0/src/merge.rs:293:9:
  not implemented: if/then/else schemas are not supported

Is this a case where the lottie team would need to make more changes or is this something that can be fixed on the typify side?

Dominant language
Rust
Stars
898
Forks
114
Avg merge
4h 18m
Merged PRs (30d)
14

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/typify

All issues in oxidecomputer/typify

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.