`block_worker_collection_*` probes should include IDs

Open Beginner friendly
#1,157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
backend

Research direction

Start in lib/propolis/src/block/attachment.rs at the referenced block_worker_collection_wake and block_worker_collection_woken probes around lines 1023–1044. Compare their probe arguments with block_strategy!() to understand the existing device identifier pattern. Done means both probes identify the device and report which device has the remaining idled-worker count.

Written by the indexing model from the issue text.

Description

development

consider the block_worker_collection_wake and block_worker_collection_woken probes here:
https://github.com/oxidecomputer/propolis/blob/d59ac2dcf1a24f08f82ea803978d7a3351525c17/lib/propolis/src/block/attachment.rs#L1023-L1044

... how does one know which device is seeing workers get kicked, and which device has what number of remaining idled workers? we'd want a device id like block_strategy!() to tell, so we should get one in there..

Dominant language
Rust
Stars
270
Forks
42
Avg merge
4d 5h
Merged PRs (30d)
6

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/propolis

All issues in oxidecomputer/propolis

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.