Stop silently ignoring spec.loadBalancerSourceRanges

Open Beginner friendly
#267 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
82/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go, kubernetes
Domain
backend, cloud

Research direction

Start in internal/provider/load_balancer.go at the top of EnsureLoadBalancer, where the existing externalTrafficPolicy check is handled. Follow that pattern for services setting spec.loadBalancerSourceRanges, then run the relevant provider tests and verify that the service receives a clear error event instead of silent non-enforcement.

Written by the indexing model from the issue text.

Description

Bug Kubernetes Cloud Controller Manager (CCM)

Context

Users set spec.loadBalancerSourceRanges expecting traffic restriction. The CCM ignores it entirely — a security surprise: the user believes their service is firewalled when it isn't.

Scope

Short term: reject services that set this field, mirroring the existing externalTrafficPolicy check at the top of EnsureLoadBalancer (internal/provider/load_balancer.go).

Long term (file separately if pursued): map source ranges to VPC firewall rules.

Done when

A service setting loadBalancerSourceRanges gets a clear error event instead of silent non-enforcement.

Dominant language
Go
Stars
6
Forks
2
Avg merge
2h 5m
Merged PRs (30d)
14

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/oxide-cloud-controller-manager

All issues in oxidecomputer/oxide-cloud-controller-manager

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.