Verify ownership before detaching/deleting a floating IP
Maintainers usually reply within 1 day
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 68/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Quiet
- Tech stack
- go
- Domain
- cloud, infrastructure
Research direction
Start in internal/provider/load_balancer.go at EnsureLoadBalancerDeleted and the recreate path in ensureLoadBalancer, then trace how the CCM creates floating IPs and sets their description. Ensure both paths refuse to detach or delete a name-colliding IP without the managed description, with the refusal visible in events or logs; verify that a user-created IP remains intact.
Written by the indexing model from the issue text.
Description
Context
EnsureLoadBalancerDeleted (internal/provider/load_balancer.go) detaches and deletes any floating IP whose name matches the computed load balancer name — including one a user created by hand. Oxide has no resource tags (HasClusterID() is false), so there's no ownership marker today.
Scope
The CCM already sets Description: "Managed by oxide-cloud-controller-manager." on create. Check that description before detach/delete (in both EnsureLoadBalancerDeleted and the recreate path in ensureLoadBalancer) and refuse with a clear error/event on mismatch.
Done when
A name-colliding, user-created floating IP is never deleted by the CCM, and the refusal is visible in events/logs.
Related: collision-proof LB names — ship both in the same release with one migration note.
- Dominant language
- Go
- Stars
- 6
- Forks
- 2
- Avg merge
- 2h 37m
- Merged PRs (30d)
- 11
Getting set up
We have not checked this project's setup files yet. Start from its README, and see our first-contribution guide for the general steps.
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from oxidecomputer/oxide-cloud-controller-manager
-
Documentation Kubernetes Cloud Controller Manager (CCM)
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
oxidecomputer/oxide-cloud-controller-manager#279 ·
Maintainers usually reply within 1 day
-
Documentation Kubernetes Cloud Controller Manager (CCM)
Difficulty 2/5 1-3 hours Newbie friendliness 90/100
oxidecomputer/oxide-cloud-controller-manager#278 ·
Maintainers usually reply within 1 day
-
Bug Kubernetes Cloud Controller Manager (CCM)
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oxidecomputer/oxide-cloud-controller-manager#276 ·
Maintainers usually reply within 1 day
-
Bug Kubernetes Cloud Controller Manager (CCM)
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
oxidecomputer/oxide-cloud-controller-manager#275 · 1 comment ·
Maintainers usually reply within 1 day
-
Enhancement Kubernetes Cloud Controller Manager (CCM)
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
oxidecomputer/oxide-cloud-controller-manager#274 ·
Maintainers usually reply within 1 day
All issues in oxidecomputer/oxide-cloud-controller-manager
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 65/100
521xueweihan/HelloGitHub#3789 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
Maintainers usually reply within 12 days
-
stage-fail
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
siyuan-note/bazaar#2282 ·
Maintainers usually reply within 1 day
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
openshift/kube-compare#307 ·
Maintainers usually reply within 1 day