Rework mockOxideClient to assert on request parameters

Open Beginner friendly

#261 opened on Jul 5, 2026 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 86/100

Issue type: Refactor
Clarity: Clearly specified
Activity status: Quiet
Tech stack: go
Domain: testing

Research direction

Start with mockOxideClient and the WithProviderID and NoProviderID subtests in internal/provider/instances_v2_test.go, then compare the function-field fake style in internal/provider/load_balancer_test.go. Run the relevant internal/provider tests and verify that getInstance uses the expected InstanceView arguments for each path and that unexpected calls fail loudly.

Written by the indexing model from the issue text.

Description

Kubernetes Cloud Controller Manager (CCM) Testing

Context

The instances mock (mockOxideClient in internal/provider/instances_v2_test.go) returns canned outputs without inspecting request parameters, so the WithProviderID and NoProviderID subtests can't actually tell the two lookup paths apart — they assert the same thing today.

Scope

Convert mockOxideClient to the function-field fake style already used by fakeOxideLBClient in internal/provider/load_balancer_test.go (an unset function field fails the call loudly with errUnexpectedOxideCall). Then assert that:

The provider-ID path calls InstanceView with the instance ID (no project).
The name path calls InstanceView with project + node name.

Done when

The two lookup paths in getInstance have distinguishable assertions, and any unexpected Oxide API call fails the test.

Dominant language: Go
Stars: 6
Forks: 2
Avg merge: 2h 5m
Merged PRs (30d): 14

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

GrafeasNote is a duplicate resource of ContainerAnalysisNote Open

Difficulty 1/5 Under an hour Newbie friendliness 84/100

GoogleCloudPlatform/k8s-config-connector#13349 · Opened Sep 21, 2026
[receiver/receiverhelper] skip WithLinks when the parent span context is invalid Open

enhancement needs triage

Difficulty 2/5 1-3 hours Newbie friendliness 68/100

open-telemetry/opentelemetry-collector#15998 · Opened Sep 21, 2026
🧹 Use PodSet wrappers in DRA tests Open

kind/cleanup

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

kubernetes-sigs/kueue#15947 · Opened Sep 21, 2026
Custom provider credential is written as `PROVIDER_API_KEY` (apiserver) but the AgentRun controller injects only allowlisted keys, so every custom provider fails with HTTP 401 Open

Difficulty 2/5 1-3 hours Newbie friendliness 78/100

sympozium-ai/sympozium#627 · Opened Sep 21, 2026
google-cloud-php: remove format step from owlbot.py now that librarian runs formatting during generate Open

priority: p3

Difficulty 2/5 1-3 hours Newbie friendliness 72/100

googleapis/librarian#7636 · Opened Sep 21, 2026

More Go issues