`InnerFlowId` should be a per-`NetworkImpl` concept

Open
#996 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Quiet
Tech stack
rust
Domain
networking

Research direction

Start with the linked lib/opte/README.adoc lines 109-113 and review the FlowId trait introduced in #990. Trace how InnerFlowId is currently tied to NetworkImpl, then assess the plumbing needed to make it per-NetworkImpl and move the trait into opte_api. Done means the concept is correctly separated without requiring a different FlowId type for the current implementation.

Written by the indexing model from the issue text.

Description

https://github.com/oxidecomputer/opte/blob/5470aa15eaa06e5183c374c1f61e5e5ddd5e0350/lib/opte/README.adoc?plain=1#L109-L113

We don't yet have any other NetworkImpl, much less one that would require a different FlowId type. Plumbing this through would be quite an involved task. When we do so, we want it to use the trait FlowId introduced in #990 -- at that time we should also move the trait into opte_api.

Dominant language
Rust
Stars
77
Forks
11
Avg merge
9d 20h
Merged PRs (30d)
8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/opte

All issues in oxidecomputer/opte

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.