Log the entire error chain when sled-agent cannot communicate with nexus

Open Beginner friendly
#9,804 16 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
rust
Domain
observability

Research direction

Start in sled-agent/src/nexus.rs around line 530, where the communication error is logged. Trace the error handling to identify how the underlying chain is currently represented, then verify the resulting log includes the full chain when sled-agent cannot communicate with Nexus.

Written by the indexing model from the issue text.

Description

When sled-agent fails to communicate with Nexus, it doesn't log the underlying error.

Example:

01:13:21.478Z WARN SledAgent: Received Error from Nexus for Get request: Communication Error: error sending request for url (http://_nexus._tcp.control-plane.oxide.internal:12221/sled-agents/<SLED_ID>)
    file = sled-agent/src/nexus.rs:530
    sled_id = <SLED_ID>

This issue is to ask for logging the whole error chain.

Dominant language
Rust
Stars
572
Forks
97
Avg merge
2d 7h
Merged PRs (30d)
92

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from oxidecomputer/omicron

All issues in oxidecomputer/omicron

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.