oxc-project/oxc

☂️ eslint-plugin-jest

Open

#492 opened on Jun 28, 2023

View on GitHub
 (8 comments) (0 reactions) (0 assignees)Rust (17,579 stars) (727 forks)batch import
A-lintergood first issue

Description

[!WARNING] This comment is maintained by CI. Do not edit this comment directly. To update comment template, see https://github.com/oxc-project/oxc/tree/main/tasks/lint_rules

This is the tracking issue for eslint-plugin-jest.

There are 71(+ 0 deprecated) rules.

  • 0/19 recommended rules are remaining as TODO
    • All done! 🎉
  • 7/52 not recommended rules are remaining as TODO

To get started, run the following command:

just new-jest-rule <RULE_NAME>

Then implement the rule and get all the tests passing.

Recommended rules

Status Name Rationale
✅ jest/expect-expect
✅ jest/no-alias-methods
✅ jest/no-commented-out-tests
✅ jest/no-conditional-expect
✅ jest/no-deprecated-functions
✅ jest/no-disabled-tests
✅ jest/no-done-callback
✅ jest/no-export
✅ jest/no-focused-tests
✅ jest/no-identical-title
✅ jest/no-interpolation-in-snapshots
✅ jest/no-jasmine-globals
✅ jest/no-mocks-import
✅ jest/no-standalone-expect
✅ jest/no-test-prefixes
✅ jest/valid-describe-callback
✅ jest/valid-expect
✅ jest/valid-expect-in-promise
✅ jest/valid-title

✅ = Implemented, 🚫 = Not intending to implement, ⏳ = Fix pending

Not recommended rules

Status Name Rationale
✅ jest/consistent-test-it
✅ jest/max-expects
✅ jest/max-nested-describe
✅ jest/no-conditional-in-test
✅ jest/no-confusing-set-timeout
✅ jest/no-duplicate-hooks
🚫 jest/no-error-equal Requires type information. Not currently possible to implement in oxlint.
✅ jest/no-hooks
✅ jest/no-large-snapshots
✅ jest/no-restricted-jest-methods
✅ jest/no-restricted-matchers
✅ jest/no-test-return-statement
🚫 jest/no-unnecessary-assertion Requires type information. Not currently possible to implement in oxlint.
✅ jest/no-unneeded-async-expect-function
✅ jest/no-untyped-mock-factory
✅ jest/padding-around-after-all-blocks
jest/padding-around-after-each-blocks
jest/padding-around-all
jest/padding-around-before-all-blocks
jest/padding-around-before-each-blocks
jest/padding-around-describe-blocks
jest/padding-around-expect-groups
✅ jest/padding-around-test-blocks
✅ jest/prefer-called-with
✅ jest/prefer-comparison-matcher
✅ jest/prefer-each
✅ jest/prefer-ending-with-an-expect
✅ jest/prefer-equality-matcher
✅ jest/prefer-expect-assertions
✅ jest/prefer-expect-resolves
✅ jest/prefer-hooks-in-order
✅ jest/prefer-hooks-on-top
✅ jest/prefer-importing-jest-globals
✅ jest/prefer-jest-mocked
✅ jest/prefer-lowercase-title
✅ jest/prefer-mock-promise-shorthand
✅ jest/prefer-mock-return-shorthand
✅ jest/prefer-snapshot-hint
✅ jest/prefer-spy-on
✅ jest/prefer-strict-equal
✅ jest/prefer-to-be
✅ jest/prefer-to-contain
✅ jest/prefer-to-have-been-called
✅ jest/prefer-to-have-been-called-times
✅ jest/prefer-to-have-length
✅ jest/prefer-todo
✅ jest/require-hook
✅ jest/require-to-throw-message
✅ jest/require-top-level-describe
🚫 jest/unbound-method Requires type information. Not currently possible to implement in oxlint.
🚫 jest/valid-expect-with-promise Requires type information. Not currently possible to implement in oxlint.
jest/valid-mock-module-path

✅ = Implemented, 🚫 = Not intending to implement, ⏳ = Fix pending

Contributor guide

Tech stack
rustjavascripttypescript
Domain
testingtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustESLint rulesJest testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look at the list of unimplemented rules (e.g., padding around after each blocks). Run `just new jest rule <RULE NAME>` to generate boilerplate. Then implement the rule logic in Rust, referencing the ESLint rule documentation at the linked URL. Ensure all tests pass.