[BUG] Lack of message when locked image file is removed from preview

Open Beginner friendly
#4,300 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
68/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
kotlin
Domain
mobile

Research direction

Start by reproducing the locked-file removal flow from the preview and compare it with removal from the file list, which already provides feedback. Trace the preview removal entry point and its error handling; done means a snackbar clearly explains that a locked file could not be removed.

Written by the indexing model from the issue text.

Description

Contributions are welcome p3-medium Type:bug

This one comes from https://github.com/owncloud/android/pull/4285#issuecomment-1908115473

Steps to reproduce
  1. Lock a picture file
  2. Open the picture in the app to preview it
  3. Remove the picture from the preview
Actual behaviour

Nothing happens

Expected behaviour

An snackbar clarifying that the file could not be removed because it's locked

In the following video, the file land1.jpg is locked. Removing from preview does not give feedback, removing from file list gives feedback:

https://github.com/owncloud/android/assets/14894746/ea5542be-d3be-4857-89fa-f8956fdd09d1

How to lock a file:

  • Try to remove a video that is being streamed from server (not a local copy)
  • In oC10 servers: Log in an admin account > Settings (top right menu) > General (left menu, admin side) > tick Enable manual file locking in the web interface. Once enabled, every file (not folder) in the list will have an option Lock file available.
Dominant language
Kotlin
Stars
4.2k
Forks
3.1k
Avg merge
1d 12h
Merged PRs (30d)
7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from owncloud/android

All issues in owncloud/android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.