overdodactyl/ShadowFox

Whiteness seen in the two "Clear History" dialogs

Open

#226 opened on Dec 10, 2018

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (1,315 stars) (65 forks)batch import
bughelp wanted

Description

OS: macOS 10.14.2 Browser version: Beta 64.0 (likely the build to be released as final tomorrow) Using complete theme via shadowfox-updater

TIL there are two "clear recent history" dialogs - the first you invoke with shift+command+delete and the second is through the "Clear History" button in about:preferences#privacy. See attached screenshot for how they currently look like:

screen shot 2018-12-10 at 12 07 32 am

Contributor guide

Tech stack
css
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic CSS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The issue is about visual whiteness in the 'Clear History' dialogs. To fix, inspect the CSS selectors for these dialogs in the theme's source files, likely within userChrome.css or similar. Check for any CSS rules that set background color to white or remove transparency. The issue may need updating for newer Firefox versions. Refer to comments in the issue for any hints.