oven-sh/bun

using `/tmp/bun-node` for overriding node.js is incorrect

Open

#7,504 opened on Dec 7, 2023

View on GitHub
 (2 comments) (2 reactions) (1 assignee)Rust (90,348 stars) (4,486 forks)batch import
buggood first issue

Description

What version of Bun is running?

No response

What platform is your computer?

No response

What steps can reproduce the bug?

If you at any point ever install bun in one place, run bun --bun, and then install it somewhere else, the second bun will use the old symlink and point to the first installation (which may be deleted)

This is rare but there are cases this can happen:

  • if you are on a machine where two people have bun installed to ~/.bun/bin/bun
  • you download any release manually and run it from your downloads folder
  • you use any other package manager to install bun that does not put it in ~/.bun/bin (if you use sudo yarn i -g, this can end up with /usr/local/bin/bun)
  • otherwise tampering with /tmp/bun-node (note: /tmp is usually mutable by any user)

a user reported this on nixos, where the binary is located at a unique path, it is pointing to a version as old as 0.6.2, though this issue isn't specific to nix.

image

What is the expected behavior?

i think a solution would be to move this into either XDG/Mac cache dir or into .bun somewhere, and/or use some hash of argv0, like bun-node-AJVZHD so that multiple installs point properly without having to fully validate them every time.

What do you see instead?

No response

Additional information

No response

Contributor guide

Tech stack
rustjavascript
Domain
backendcli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of Bun runtimeNode.js compatibility layerFile system symlinksXDG base directory specification
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look at how the /tmp/bun node symlink is created and managed in the Bun runtime (likely in the node compatibility code). Investigate the proposed solutions: moving the symlink to an XDG cache directory or using a hash of argv0 to avoid collisions. Check the codebase for any existing references to bun node and understand the current flow. Note that this issue is assigned, so consider if the assignee has provided any additional context in comments.