otland/forgottenserver

Missing isCorpse check at ProtocolGame::sendContainer

Open

#3,855 opened on Dec 16, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)C++ (1,145 forks)auto 404
featuregood first issuepriority: low

Repository metrics

Stars
 (1,813 stars)
PR merge metrics
 (PR metrics pending)

Description

Before creating an issue, please ensure:

  • This is a bug in the software that resides in this repository, and not a support matter (use https://otland.net/forums/support.16/ for support)
  • This issue is reproducible without changes to the C++ code in this repository

Steps to reproduce (include any configuration/script required to reproduce)

  1. Kill a monster
  2. Open its corpse
  3. Move any item to inside the corpse

Expected behaviour

Should not be possible, a red square will appear in the slot you are trying to move it to

Actual behaviour

You can add any item to monster corpses

Explanation

I don't know since when it was added, but its there on official, and I think it was done to prevent some analyzers to not contain misinformation

Related code

here is the part that need a isCorpse() check

PS

Make it configurable, but enabled by default

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.