orhun/git-cliff

Use stable rust for cargo-fmt

Open

#618 opened on Apr 21, 2024

View on GitHub
 (2 comments) (2 reactions) (1 assignee)Rust (308 forks)auto 404
feature/requestgood first issue

Repository metrics

Stars
 (12,040 stars)
PR merge metrics
 (PR metrics pending)

Description

Is there an existing issue or pull request for this?

  • I have searched the existing issues and pull requests

Feature description

Not really a feature. working with cargo nightly for cargo fmt is painful :( Please, consider switching to stable to make the experience of contributors a bit better.

Desired solution

  • Remove rust-toolchain.toml file
  • Run cargo fmt

Downside: all opened PRs will have merge conflicts probably because stable uses spaces instead of tabs. So it's better to do this when there aren't big PRs opened.

Alternatives considered

The alternative is keeping the current configuration I guess.

Additional context

feedback coming from https://github.com/orhun/git-cliff/pull/613#issuecomment-2059908791

Contributor guide

Research direction
Remove the rust toolchain.toml file and run 'cargo fmt' to use stable Rust formatting. Coordinate with maintainers to avoid merge conflicts with open PRs.
Tech stack
rust
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90