organicmaps/organicmaps

Handle implied access

Open

#6,089 opened on Sep 22, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (761 forks)batch import
GeneratorGood first issue

Repository metrics

Stars
 (7,887 stars)
PR merge metrics
 (Avg merge 13d 6h) (91 merged PRs in 30d)

Description

In the case of service=emergency_access, it's implied that access=emergency, or at least vehicle=emergency.

I think the best way would be to add a new flag to replaced_tags.txt that only adds a tag if it doesn't already exist. Then we can do something like service=emergency_access : access=emergency | n

Should fix cases like https://github.com/organicmaps/organicmaps/issues/5983, where access is implied but not explicitly tagged

image

there are 26k ways worldwide tagged service=emergency_access, but without an access=* or vehicle=* so it'd be good to fix this. (to be fair, some of these may have gates with explicit access tagging)

Contributor guide

Research direction
Examine the replaced tags.txt file structure and implement a new flag that adds a tag only if it doesn't already exist, then test with service=emergency access.
Tech stack
cpp
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65