ordinals/ord

Encrypted wallet support

Open

#4,132 opened on Dec 12, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (1,479 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (3,955 stars)
PR merge metrics
 (PR metrics pending)

Description

Problem

Bitcoin Core wallet supports encrypting wallets using passphrase, since ord use it's rpc interface, do you guys think it's a good idea to also support this in ord? To achive this, we need to add an addition optional parameter(for example: password) to wallet create subcommand.

Pro

  • It will maintain ord wallet's security even when wallet file is leaked.

Con

  • When wallet is encryped, before doing any signing related operations(such as inscribe, etching, send, etc), we need to use bitcoin-cli walletpassphrase command to unlock wallet for some limited time.

Contributor guide

Research direction
Add an optional password parameter to the wallet create subcommand. Implement wallet encryption using Bitcoin Core's wallet encryption mechanism via RPC calls (walletpassphrase, encryptwallet). Ensure that encrypted wallet state is handled correctly for signing operations.
Tech stack
rust
Domain
backendsecurityblockchain
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustBitcoin wallet conceptsord codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45