oracle/cluster-api-provider-oci

Confirm pagination on all list call

Open

#97 opened on May 25, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (1 assignee)Go (48 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (55 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be added: We need this to run through all pages and return the full list of running instances https://github.com/oracle/cluster-api-provider-oci/blob/main/cloud/scope/machine_pool.go#L158

Also should check all other list calls are using pagination.

Why is this needed: As clusters grow we want to make sure we don't miss running instances.

Contributor guide

Research direction
Inspect the file cloud/scope/machine pool.go line 158 and audit all other list calls in the codebase to ensure pagination is properly implemented to avoid missing running instances.
Tech stack
go
Domain
backendapicloud
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70