Firewall: Rules: expand src/dst port validation to include SCTP

Open Beginner friendly
#10,177 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
84/100
Issue type
Feature
Clarity
Clearly specified
Activity status
Quiet
Tech stack
php
Domain
backend

Research direction

Start in src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php at lines 52-64, where source and destination port validation currently permits TCP and UDP. Extend that validation to include SCTP, then verify that SCTP rules can select source and destination ports without changing other protocol behavior.

Written by the indexing model from the issue text.

Description

Important notices

Before you add a new report, we ask you kindly to acknowledge the following:

Is your feature request related to a problem? Please describe.

As per https://github.com/opnsense/core/blob/master/src/opnsense/mvc/app/models/OPNsense/Firewall/Filter.php#L52-L64 only UDP/TCP can select source/destination ports. These should also be available for SCTP.

Describe the solution you like

Expand the validation above to include SCTP.

Describe alternatives you considered

N/A

Additional context

N/A

Dominant language
PHP
Stars
4.7k
Forks
993
Avg merge
23h 58m
Merged PRs (30d)
39

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opnsense/core

All issues in opnsense/core

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.