openzipkin/zipkin

Special case Elasticsearch 7.8+ Composable index templates

Open

#3,138 opened on Jul 6, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Java (3,079 forks)batch import
elasticsearchenhancementhelp wanted

Repository metrics

Stars
 (16,912 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Feature: If we prefer composable templates or otherwise prioritize our index templates, we can avoid support problems like https://github.com/openzipkin/zipkin-support/issues/23 where the template doesn't kick in due to something else matching on '*'

Rational Composeable templates are both introduced and preferred in ES 7.8+, which refers to _template as legacy ones.

This would introduce an issue of composeable template priority, either it would have to determine automatically what value should be set or be parameterizable through env variable.

Example Scenario Test would have a pre-existing composable template and ours still applies

Thanks @benqs for the hint. cc @openzipkin/elasticsearch

Contributor guide

Research direction
Research how Zipkin currently handles index templates in Elasticsearch, then implement support for composable templates introduced in ES 7.8, possibly via an environment variable to control priority.
Tech stack
java
Domain
backendinfrastructure
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ElasticsearchJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40