openzipkin/zipkin

Special case Elasticsearch 7.8+ Composable index templates

Open

#3138 opened on Jul 6, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Java (16,912 stars) (3,079 forks)batch import
elasticsearchenhancementhelp wanted

Description

Feature: If we prefer composable templates or otherwise prioritize our index templates, we can avoid support problems like https://github.com/openzipkin/zipkin-support/issues/23 where the template doesn't kick in due to something else matching on '*'

Rational Composeable templates are both introduced and preferred in ES 7.8+, which refers to _template as legacy ones.

This would introduce an issue of composeable template priority, either it would have to determine automatically what value should be set or be parameterizable through env variable.

Example Scenario Test would have a pre-existing composable template and ours still applies

Thanks @benqs for the hint. cc @openzipkin/elasticsearch

Contributor guide

Tech stack
javaelasticsearch
Domain
backenddatabase
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Elasticsearch index templatesZipkin storage conceptsJava
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Research Elasticsearch 7.8+ composable index templates and their priority mechanism. Examine the existing index template configuration in the Zipkin codebase (likely in the elasticsearch storage module). Consider how to detect ES version and either automatically use composable templates or provide an environment variable to enable them. There is no existing PR or maintainer comment to guide the implementation, so you may need to open a discussion thread to clarify the desired behavior.