openzipkin/zipkin

Add benchmarks

Open

#1226 opened on Aug 10, 2016

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Java (16,912 stars) (3,079 forks)batch import
help wanted

Description

From @adriancole on November 17, 2015 3:21

Some aspects of code need to be benchmarked as they will be run a lot.

Here's some ideas... feel free to contribute!

For each scenario, use traces of 1-5 depth and 10-200 width, where spans range from local to remote w/up to 2KB annotation sizes.

Library Microbenchmarks:

  • thrift and json codec
  • time skew adjustment

Integration Benchmarks (ex server running against each spanstore impl)

  • accepts/second for 1, 10, 100 length spans in json vs thrift
  • at rest size of 10K - 1M traces:
  • service/span name query latency
  • duration query latency
  • dependency query latency

Copied from original issue: openzipkin/zipkin-java#45

Contributor guide

Tech stack
java
Domain
performancetesting
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaJMH
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
This issue requests adding benchmarks for Zipkin library components and integration tests. Start by setting up JMH (Java Microbenchmark Harness) as the benchmarking framework. Focus on the microbenchmarks first: Thrift and JSON codec performance, and time skew adjustment. Reference existing test files in the repository for setup. For integration benchmarks, you'll need to run a Zipkin server against span store implementations (e.g., Elasticsearch, Cassandra). The original issue (openzipkin/zipkin java#45) may have additional discussion. After implementing a benchmark for one scenario, seek maintainer feedback before expanding.