openzipkin/zipkin-js

Using the Zipkin Postgres with sequelize

Open

#455 opened on Nov 5, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (167 forks)auto 404
help wanted

Repository metrics

Stars
 (569 stars)
PR merge metrics
 (PR metrics pending)

Description

We would love to use the zipkin-instrumentation-postgres package for tracing our Postgres calls. However, we are using an ORM which is called sequelize. This wraps the client, so the client is not available to be wrapped by the zipkin Postgres package. How would one do this? I have found an issue which kind of explains what I'm trying to do: https://github.com/openzipkin/zipkin-js/issues/227. It seems like sequelize can use CLS, although I'm unsure for what reason. I guess only for passing the transaction around without manually doing it.

Do you know any way to make this work without writing our own zipkin instrumentation for sequelize?

Contributor guide

Research direction
Tech stack
Domain
Issue type
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Prerequisites
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.