HTML rewriting: also rewrite `poster` attribute

Open Beginner friendly
#339 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
web-dev

Research direction

Start by reviewing pull request #338 and the repository's HTML rewriting implementation to find where HTML attributes are rewritten. Add handling for the poster attribute alongside the existing rewritten attributes, then verify that the behavior matches the adaptation described in pull request #338.

Written by the indexing model from the issue text.

Description

bug

https://github.com/openzim/python-scraperlib/pull/338 identified that when rewriting HTML, we do not rewrite of the poster attribute.

This should be added because it is clearly just a detail we have overlooked IMHO (and https://github.com/openzim/python-scraperlib/pull/338 changes adapted accordingly to also handle the poster attribute).

Dominant language
Python
Stars
31
Forks
27
Avg merge
3d 7h
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openzim/python-scraperlib

All issues in openzim/python-scraperlib

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.