openzfs/zfs

Ability to specify type to 'zfs destroy`

Open

#9,522 opened on Oct 28, 2019

View on GitHub
 (5 comments) (15 reactions) (0 assignees)C (9,908 stars) (1,703 forks)batch import
Type: Featuregood first issue

Description

System information

Type Version/Name
Distribution Name all
Distribution Version all
Linux Kernel all
Architecture all
ZFS Version all
SPL Version all

Describe the problem you're observing

There are no safeguards when destroying. Whatever is the argument of zfs destroy, it will get destroyed. Issuers of the destroy command are humans and humans can make mistakes: for example in shell scripts that generate destroy commands, typos etc.

A minimal protection mechanism could reject a destroy action if the type of the dataset to be destroyed does not match the dataset type specified in command line, similar to how zfs list -t works, so for example zfs destroy -t filesystem pool/volumename or zfs destroy -t snapshot pool/filesystem would fail.

Describe how to reproduce the problem

Include any warning/errors/backtraces from the system logs

Contributor guide

Tech stack
cshell
Domain
cli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C programmingZFS dataset types
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the implementation of the destroy command in cmd/zfs/zfs main.c. Study how the t flag works in zfs list for type filtering. Determine where dataset type is retrieved in the destroy code path. Look at how the ZFS IOC DESTROY ioctl handles type information. Consider adding a new flag like t and validating the dataset type against the argument. Review any existing discussions in the issue comments for design considerations.