openzfs/zfs

zpool status - cache and spare names inconsistent

Open

#9,383 opened on Sep 30, 2019

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C (9,908 stars) (1,703 forks)batch import
Bot: Not StaleType: Defectgood first issue

Description

System information

Type Version/Name
Distribution Name Ubuntu
Distribution Version 18.04.2 LTS
Linux Kernel 4.15.0-48-generic
Architecture x86_64
ZFS Version 0.8.0-1
SPL Version 0.8.0-1

Describe the problem you're observing

The command zpool status shows cache and spare vdevs with Linux 'sd' style names when the device was added with vdev_id. For spares, this is maintained when the spare is used. The same may be true of log vdevs, I'm not sure.

Describe how to reproduce the problem

The spare has been activated in this case. Also note that we probably have a bad port/expander as we have had multiple drive failures in the same slot.

I expect to see 2:9 and 2:10 in the output, not sdai and sdah.

Output:


# zpool history nice_pool | grep -E '(cache|spare)'
2019-07-15.19:09:12 zpool add -f nice_pool spare 2:9
2019-07-15.19:09:13 zpool add -f nice_pool cache 2:10

# zpool status nice_pool
  pool: nice_pool
 state: DEGRADED
  scan: resilvered 2.67T in 0 days 21:52:48 with 0 errors on Sat Sep 28 13:44:33 2019
config:

	NAME               STATE     READ WRITE CKSUM
	nice_pool       DEGRADED     0     0     0
	  raidz3-0         DEGRADED     0     0     0
	    1:0            ONLINE       0     0     0
	    1:1            ONLINE       0     0     0
	    1:2            ONLINE       0     0     0
	    1:3            ONLINE       0     0     0
	    1:4            ONLINE       0     0     0
	    1:5            ONLINE       0     0     0
	    1:6            ONLINE       0     0     0
	    1:7            ONLINE       0     0     0
	    spare-8        DEGRADED     0     0     0
	      replacing-0  UNAVAIL      0     0     0  insufficient replicas
	        old        FAULTED      0    11     0  too many errors
	        old        FAULTED      0    46     0  too many errors
	        1:8        FAULTED      0    39     0  too many errors
	      sdah         ONLINE       0     0     0
	    1:9            ONLINE       0     0     0
	    1:10           ONLINE       0     0     0
	  raidz3-1         ONLINE       0     0     0
	    1:11           ONLINE       0     0     0
	    1:12           ONLINE       0     0     0
	    1:13           ONLINE       0     0     0
	    1:14           ONLINE       0     0     0
	    1:15           ONLINE       0     0     0
	    1:16           ONLINE       0     0     0
	    1:17           ONLINE       0     0     0
	    1:18           ONLINE       0     0     0
	    1:19           ONLINE       0     0     0
	    1:20           ONLINE       0     0     0
	    1:21           ONLINE       0     0     0
	  raidz3-2         ONLINE       0     0     0
	    1:22           ONLINE       0     0     0
	    1:23           ONLINE       0     0     0
	    2:0            ONLINE       0     0     0
	    2:1            ONLINE       0     0     0
	    2:2            ONLINE       0     0     0
	    2:3            ONLINE       0     0     0
	    2:4            ONLINE       0     0     0
	    2:5            ONLINE       0     0     0
	    2:6            ONLINE       0     0     0
	    2:7            ONLINE       0     0     0
	    2:8            ONLINE       0     0     0
	cache
	  sdai             ONLINE       0     0     0
	spares
	  sdah             INUSE     currently in use

errors: No known data errors

Contributor guide

Tech stack
c
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingZFS vdev naming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Investigate the zpool status command implementation in the ZFS source repository, focusing on how vdev names are displayed. Look for code that handles cache and spare vdevs specifically, likely in cmd/zpool/zpool main.c or lib/libzfs/libzfs pool.c. The issue is that vdev id mappings are not used for cache and spare devices. Examine the function that determines the display name and ensure it applies the same logic for all vdev types.