openzfs/zfs

vdev_add event does not include vdev info

Open

#7,107 opened on Jan 31, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (9,908 stars) (1,703 forks)batch import
Type: Featuregood first issue

Description

System information

Type Version/Name
Distribution Name CentOS Linux
Distribution Version 7 (Core)
Linux Kernel 3.10.0-693.5.2
Architecture x86_64
ZFS Version 0.7.5-1
SPL Version 0.7.5-1

Describe the problem you're observing

consider zpool add tank /virtualfs2

this emits an event like:

IFS= 	
PATH=/usr/bin:/bin:/usr/sbin:/sbin
PWD=/
SHLVL=1
ZDB=/sbin/zdb
ZED=/sbin/zed
ZED_PID=26595
ZED_ZEDLET_DIR=/etc/zfs/zed.d
ZEVENT_CLASS=sysevent.fs.zfs.vdev_add
ZEVENT_EID=215
ZEVENT_POOL=tank
ZEVENT_POOL_CONTEXT=0
ZEVENT_POOL_GUID=0x576058F099B118E7
ZEVENT_POOL_STATE=0
ZEVENT_POOL_STATE_STR=ACTIVE
ZEVENT_SUBCLASS=vdev_add
ZEVENT_TIME=1517416348 27179838
ZEVENT_TIME_NSECS=27179838
ZEVENT_TIME_SECS=1517416348
ZEVENT_TIME_STRING=2018-01-31 11:32:28-0500
ZEVENT_VERSION=0
ZFS=/sbin/zfs
ZFS_ALIAS=zfs-0.7.5-1
ZFS_RELEASE=1
ZFS_VERSION=0.7.5
ZINJECT=/sbin/zinject
ZPOOL=/sbin/zpool
_=/usr/bin/printenv

I would expect this event to contain VDEV related info like ZEVENT_VDEV_PATH.

Contributor guide

Tech stack
c
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C programmingZFS event subsystemvdev structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
15
Research direction
Investigate the ZFS event generation code to identify where vdev add events are constructed. Compare with vdev remove or other events that already include ZEVENT VDEV PATH. The relevant files are likely in module/zfs/ such as spa.c or vdev.c. Add the missing field by following the pattern used for similar events. Confirm that the vdev path is available at the point of event posting.