openzfs/zfs

Warning about deduplication is not accurate

Open

#2829 opened on Oct 24, 2014

View on GitHub
 (6 comments) (0 reactions) (0 assignees)C (9,908 stars) (1,703 forks)batch import
Type: Documentationgood first issue

Description

The warning introduced by 971808ec9f62bc3f8e0347ebace6a19429d4e61d about data duplication is not accurate. I did a write-up about why the rule of thumb provided is not accurate:

https://news.ycombinator.com/item?id=8437921

@FransUrbo I do not really want to have people spreading FUD quote the man page when I try to explain how things actually work. This message should be amended for accuracy.

Contributor guide

Tech stack
c
Domain
infrastructure
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Familiarity with ZFS deduplicationC programming basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue references a HN comment explaining why the deduplication warning is inaccurate. The warning was introduced in commit 971808ec9f62bc3f8e0347ebace6a19429d4e61d. To resolve, locate that warning message in the codebase, read the HN link, and amend the message to be accurate. No assignee or PR exists. The issue is old and may require understanding of deduplication internals.