openwisp/django-loci

[bug] ObjectLocation admin doesn't work in readonly mode

Open

#95 opened on Oct 8, 2021

View on GitHubContributor guide
 (9 comments) (0 reactions) (1 assignee)Python (54 forks)auto 404
bughacktoberfest

Repository metrics

Stars
 (194 stars)
PR merge metrics
 (PR metrics pending)

Description

When a user has only view permission, the map doesn't work because the JS fails (it was not tested in this scenario).

Contributor guide

Research direction
Inspect the admin template for ObjectLocation to find where the map JavaScript is loaded. Check if there is a permission check that might skip loading the map JavaScript for users with only view permission. Then ensure the JavaScript gracefully handles missing DOM elements.
Tech stack
pythonjavascriptdjango
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
DjangoJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70