opentypejs/opentype.js

Corrupted font file handling

Open

#337 opened on Mar 16, 2018

View on GitHub
 (4 comments) (0 reactions) (1 assignee)JavaScript (4,170 stars) (512 forks)batch import
enhancementhelp wantedquestion

Description

The more different tables we parse in opentype.js, the more we come across corrupted font files. Most of them are still usable with other software, but opentype.js currently throws errors and stops parsing the font. Shouldn't we try to skip (sub)tables containing errors ? Should we report errors in some way ? Maybe just keeping a log of ignored tables ? What do you think ? @fdb @Jolg42 @Pomax and others ?

Contributor guide

Tech stack
javascript
Domain
backendtooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
OpenType specificationopentype.js codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the assigned user's existing work or comments on this issue. Explore the opentype.js source code, particularly the table parsing functions (src/tables/*.js). Propose a solution that gracefully skips corrupted tables and logs errors without halting parsing. Consider adding a configuration option to enable/disable strict mode.
Corrupted font file handling · opentypejs/opentype.js#337 | Good First Issue