openstreetmap/iD

Deleting nodes from an area doesn't check to see if the area self-intersects

Open

#9,625 opened on May 2, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)JavaScript (1,449 forks)github user discovery
help wantedvalidation

Repository metrics

Stars
 (3,818 stars)
PR merge metrics
 (Avg merge 29d 14h) (82 merged PRs in 30d)

Description

URL

No response

How to reproduce the issue?

  1. Create an area with a sharp corner
  2. Delete nodes until the way crosses over itself
  3. Save and upload without a warning

Screenshot(s) or anything else?

Screen recording here: https://drive.google.com/file/d/1bocercK5ZcbfPDyv6Z0dt0mKYy2J2nxy/view?usp=sharing

Changeset shown in recording is https://osmcha.org/changesets/135619665/

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.25.2

Which browsers are you seeing this problem on?

Chrome

Contributor guide

Research direction
Examine the validation logic for area self intersection in the iD editor. Focus on the code that runs when nodes are deleted from an area. Look for where intersection checks are performed and why they might be skipped.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75