openstreetmap/iD

Improve multiple selection tag value display - show value and unset count

Open

#8,829 opened on Nov 30, 2021

View on GitHubContributor guide
 (2 comments) (2 reactions) (0 assignees)JavaScript (1,449 forks)github user discovery
enhancementfieldhelp wanted

Repository metrics

Stars
 (3,818 stars)
PR merge metrics
 (Avg merge 29d 14h) (82 merged PRs in 30d)

Description

In JOSM if you select multiple objects the display of tag values is different to iD. For example it will say:

  • <1 'value', 2 unset>
  • <2 different, 1 unset>
  • <3 different>

Whereas in iD it will just say "Multiple Values" and even when there is an unset tag value. Instead with three selected ways tagged lit=no, lit=yes and no lit tag, it could say for example:

  • 2 values, 1 unset

unset

At the very least it would be good to have the numbers of each value in brackets in the dropdown, along with an "unset" value if there is an object without a value.

Contributor guide

Research direction
Examine the UI component that displays tag values for multiple selections. Modify it to show value counts and an unset count instead of ' Multiple Values '. Look at how JOSM handles this for inspiration.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptiD internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70