openstreetmap/iD

Add a parameter to support custom {tileSize} of WMTS backgrounds

Open

#8,688 opened on Sep 13, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,449 forks)github user discovery
help wanted

Repository metrics

Stars
 (3,818 stars)
PR merge metrics
 (Avg merge 29d 14h) (82 merged PRs in 30d)

Description

I see the current logic is 256 by default

https://github.com/openstreetmap/iD/blob/bc0c1895f7b240a35e1beb6b9220eb15d8c36a70/modules/renderer/background_source.js#L51

Of course for some exceptions there are few hacks:

https://github.com/openstreetmap/iD/blob/1ee45ee1f03f0fe4d452012c65ac6ff7649e229f/scripts/update_imagery.js#L94-L101

Wouldn't it be better to add a parameter for custom backgrounds to define the tileSize by themselves? If iD supports this, ELI will be able to add more WMTS sources.

Currently only JOSM can handle 512x512 automatically because it reads WMTSCapabilities directly.

A WMTS service cannot be opened in iD 2.20.1: https://geodata.md.gov/imap/rest/services/Imagery/MD_SixInchImagery/MapServer/WMTS/1.0.0/WMTSCapabilities.xml

Contributor guide

Research direction
Add a configurable tileSize parameter to the background source and propagate it to WMTS handling. Ensure the custom tileSize is used in the tile loading logic instead of the default 256.
Tech stack
javascript
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70