Change the validation rule with overlapping buildings

Open Beginner friendly
#11,058 5 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
javascript
Domain
frontend, web-dev

Research direction

Locate the iD validation rule for overlapping buildings and inspect how it produces the current warning and layer suggestions. Reproduce an overlapping-building case, then verify that the warning remains while suggestions to add layer=1 or layer=-1 are no longer offered.

Written by the indexing model from the issue text.

Description

usability validation

When two buildings overlap, it is usually a mistake to be corrected manually, i.e. the buildings are actually standing next to each other, but have been connected inaccurately. Don't let the iD editor suggest to add layer=1 or layer=-1, because people mindlessly click it and strange silly things come out. The warning can stay, but without suggesting adding a layer. Cases where one building is above another are very rare.

Dominant language
JavaScript
Stars
3.9k
Forks
1.5k
Avg merge
5d 3h
Merged PRs (30d)
44

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from openstreetmap/iD

All issues in openstreetmap/iD

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.