openstreetmap/iD

Different algorithms for straightening ways and nodes

Open

#10,202 opened on Apr 14, 2024

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,449 forks)github user discovery
help wantedoperation

Repository metrics

Stars
 (3,818 stars)
PR merge metrics
 (Avg merge 29d 14h) (82 merged PRs in 30d)

Description

URL

No response

How to reproduce the issue?

  1. Create 5 nodes which are not in line and apply any preset to them
  2. Copy and paste the nodes
  3. Create a line that follows the first five nodes
  4. Straighten the line (notice that the two end nodes don't move)
  5. Select the five free nodes and straighten then (notice that the end nodes move)

It would be best if the end nodes stay at their location since it's a lot easier to straighten trees/shops/benches/bins that way instead of having to make dummy lines.

Screenshot(s) or anything else?

No response

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit

What version numbers does this issue effect?

2.28.1

Which browsers are you seeing this problem on?

Firefox

Contributor guide

Research direction
Investigate the straightening algorithm for nodes and ways in the iD editor. Look at the code for 'straighten' action, specifically how it handles end nodes. Ensure that when straightening a set of free nodes (not part of a way), the end nodes remain fixed at their original positions, similar to how they behave when straightening a way.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70