openssl/openssl

Misjudgment of CRL Distribution Points extension

Open

#26,161 opened on Dec 12, 2024

View on GitHub
 (3 comments) (0 reactions) (1 assignee)C (11,262 forks)batch import
branch: masterhelp wantedtriaged: feature

Repository metrics

Stars
 (30,157 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

RFC5280 describes this extension as follows: When a conforming CA includes a cRLDistributionPoints extension in a certificate, it MUST include at least one DistributionPoint that points to a CRL that covers the certificate for all reasons. I provided a test case that included a CRL distribution point extension, but the extension value was empty, which does not comply with RFC5280. I used the this certificate to conduct a format conversion experiment.Golang throws error for certificate: invalid CRL distribution points, but openssl incorrectly conversion successful. cert.zip image

Contributor guide

Research direction
Compare OpenSSL's CRL Distribution Points validation logic against RFC5280 and Go's implementation. Focus on the case where the extension is present but empty. Check the certificate parsing code in crypto/x509v3/ and verify the error handling.
Tech stack
c
Domain
security
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
X.509 certificate parsingRFC5280
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40