openssl/openssl

Add check of result chmod() in RAND_file_name(...)

Closed

#25,143 opened on Aug 8, 2024

View on GitHubContributor guide
 (3 comments) (0 reactions) (1 assignee)C (11,262 forks)batch import
help wantedtriaged: bug

Repository metrics

Stars
 (30,157 stars)
PR merge metrics
 (PR metrics pending)

Description

OpenSSL 3.0.14

In the function RAND_file_name(), chmod(file, 0600) is executed on line 249. But the result of the chmod(...) function execution is not checked. Maybe it is worth checking the result, because chmod(...) should restrict permissions and its successful execution seems important?

Contributor guide

Research direction
Locate the RAND file name function in OpenSSL source, specifically the call to chmod() on line 249 (likely in randfile.c). Add a check for the return value of chmod(); if it fails, log an error or return an appropriate error code. Consider the implications of a failed chmod (e.g., permissions not set) and ensure the error is handled gracefully.
Tech stack
c
Domain
security
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75