openssl/openssl

a sm4-xts aarch64 assembly code bug when 'VPSM4_EX_CAPABLE' is turn on

Closed

#23,316 opened on Jan 17, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C (11,262 forks)batch import
branch: 3.2branch: masterhelp wantedtriaged: bug

Repository metrics

Stars
 (30,157 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

A bug is found when fuzzing sm4-xts implementation on Kunpeng920. It is triggered when 'VPSM4_EX_CAPABLE' is turn on, and the XTSStandard is GB. A test vector

Cipher = SM4-XTS
Key = FFFEFDFCFBFAF9F8F7F6F5F4F3F2F1F0BFBEBDBCBBBAB9B8B7B6B5B4B3B2B1B0
IV = 9A785634120000000000000000000000
Plaintext = 000102030405060708090A0B0C0D0E0F10
Ciphertext =  9E52443A35410CA0BA5637B94C0766F469
XTSStandard = GB

Contributor guide

Research direction
Examine the aarch64 assembly implementation of SM4 XTS in the OpenSSL codebase, specifically the file 'crypto/sm4/asm/sm4 armv8.pl' or similar. Investigate the code path when VPSM4 EX CAPABLE is enabled, focusing on the GB standard branch. Compare with the provided test vector to identify discrepancies. Check if there are any open PRs or comments addressing this issue.
Tech stack
c
Domain
security
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
5
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C programmingAArch64 assemblySM4 block cipherOpenSSL cryptography library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
10