opensearch-project/OpenSearch

[Remote Store] Adding negative test case in RemoteStoreRepositoryRegistrationIT

Open

#9,675 opened on Aug 31, 2023

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Java (1,505 forks)batch import
StorageStorage:Remoteenhancementgood first issue

Repository metrics

Stars
 (8,123 stars)
PR merge metrics
 (Avg merge 5d 9h) (266 merged PRs in 30d)

Description

RemoteStoreRepositoryRegistrationIT supports only the positive test case while all the positive and negative test case is present in JoinTaskExecutorTests. Need to add more negative ITs

  • The node join fails due to node attribute values being different during bootstrap.
  • Node join fails if a node goes out of cluster and tries to join back with different attributes.
  • A non remote store node trying to join a remote store cluster.
  • A remote store node trying to join a non remote store cluster.
  • Node join fails due to repository creation fails.
  • Node join fails due to repository verification fails.

Additional context https://github.com/opensearch-project/OpenSearch/pull/9105#discussion_r1306914007

Contributor guide

Research direction
Examine the existing RemoteStoreRepositoryRegistrationIT and JoinTaskExecutorTests to understand the test patterns. For each unchecked item, identify the expected failure condition and implement a test that verifies the error handling logic.
Tech stack
java
Domain
backenddatabase
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaJUnitIntegration testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65