opensearch-project/OpenSearch

Code Duplication in Cloud Plugins

Open

#2,155 opened on Feb 17, 2022

View on GitHub
 (7 comments) (0 reactions) (1 assignee)Java (1,505 forks)batch import
enhancementgood first issuehacktoberfest

Repository metrics

Stars
 (8,123 stars)
PR merge metrics
 (Avg merge 5d 9h) (266 merged PRs in 30d)

Description

Is your feature request related to a problem? Please describe. There seems to be duplication of logic in the code for Cloud Plugins. This is an opportunity for us to streamline the codebase and refactor these classes. This issue stems from these comments in #2096.

Describe the solution you'd like Move common functionality to superclasses and have the Cloud Plugins inherit/extend these in platform-specific subclasses.

Describe alternatives you've considered N/A

Additional context N/A

Contributor guide

Research direction
Identify duplicated code in cloud plugin classes and design abstract superclass with common functionality, then refactor subclasses.
Tech stack
java
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaOOP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60